Ikoka Handheld compile and LED fixes#35
Open
andyshinn wants to merge 4 commits intoweebl2000:dev_plusfrom
Open
Ikoka Handheld compile and LED fixes#35andyshinn wants to merge 4 commits intoweebl2000:dev_plusfrom
andyshinn wants to merge 4 commits intoweebl2000:dev_plusfrom
Conversation
andyshinn
commented
Mar 2, 2026
andyshinn
commented
- Fix compiling on Ikoka Handheld
- Fix LED inverted
- Add status LED
There was a problem hiding this comment.
Pull request overview
This PR updates the Ikoka Handheld NRF52 variant configuration to fix build settings and align LED behavior with the board’s wiring, including adding a dedicated status LED pin.
Changes:
- Fix Ikoka Handheld build configuration by setting the PlatformIO board + linker script and correcting env inheritance.
- Fix inverted LED logic by updating
LED_STATE_ONfor this variant. - Add a
PIN_STATUS_LEDdefinition and initialize it during board startup.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| variants/ikoka_handheld_nrf/variant.h | Updates LED active state and adds PIN_STATUS_LED mapping. |
| variants/ikoka_handheld_nrf/platformio.ini | Adds board/ldscript config and fixes env extends to use the correct base section. |
| variants/ikoka_handheld_nrf/IkokaNrf52Board.cpp | Initializes the status LED pin at startup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.